xLights Bug: Shock...
 
Notifications
Clear all

xLights Bug: Shockwave flicker on outer edges

11 Posts
4 Users
0 Reactions
3,587 Views
Posts: 114
Topic starter
(@dmpeaceman)
Estimable Member
Joined: 16 years ago
[#42799]

I don't know where to submit bug reports, so apologies if this isn't the right forum. But the Shockwave effect seems to have a bug when applied to my whole house model.

It will be fine until it reaches the full size, then the outer sides will start to flicker random pixels. I've tried moving things a bit to see if it had to do with positions, and updating settings, but nothing seemed to fix it.

Version: 2016.48

Settings:

settings

Video of issue

Screenshot of issue

shockwave

I'm curious if this might be due to my whole house image dimensions, as it's very wide. 2.33:1 aspect ratio (643x1500). Here's my background image for reference:

House background

10 Replies
Posts: 1015
(@gilrock)
Noble Member
Joined: 14 years ago

Any of the effects that render based on iterating around in a circle based on step angle are eventually going to start showing holes. The problem is the smaller the step angle the render times increase dramatically. So we've made it try to adjust the step angle based on the model size. The smallest step angle should work for a 400x400 model which is the default grid for a model group. If you changed that number to be bigger dimensions then yes you will get a few holes like this. Do a search on moire pattern if you want to know why it happens. Its not a bug its a hard-coded limit to how big a model we guarantee no holes.


Reply
Posts: 114
Topic starter
(@dmpeaceman)
Estimable Member
Joined: 16 years ago
Gilrock wrote:Any of the effects that render based on iterating around in a circle based on step angle are eventually going to start showing holes. The problem is the smaller the step angle the render times increase dramatically. So we've made it try to adjust the step angle based on the model size. The smallest step angle should work for a 400x400 model which is the default grid for a model group. If you changed that number to be bigger dimensions then yes you will get a few holes like this. Do a search on moire pattern if you want to know why it happens. Its not a bug its a hard-coded limit to how big a model we guarantee no holes.

thanks for the reply - makes sense. Guessing there isn't a work-around, unless I made my layout square?


Reply
Posts: 1015
(@gilrock)
Noble Member
Joined: 14 years ago

So what is your model layout size? Its not the resolution of your background image.


Reply
jeffu231
Posts: 2457
(@jeffu231)
Famed Member
Joined: 15 years ago

When I ported the shockwave to Vixen, I had the same problem when doing the equivalent of the whole display model. I rewrote the logic that does that to to calculate the inner and outer circles and determine if the pixel location was within the two circles. It turned out to be way more performant than the blind rotating angle logic. I have actually redone many of them to drive the logic from the existing pixels that are really there and ignoring the empty positions in the virtual matrix. I was able to achieve large performance gains in the rendering. Maybe some of those ideas might translate.

Food for thought.

Sent from my iPhone using Tapatalk


Reply
Posts: 1015
(@gilrock)
Noble Member
Joined: 14 years ago

I'm a little too busy writing the next feature you'll be copying...lol.


Reply
jeffu231
Posts: 2457
(@jeffu231)
Famed Member
Joined: 15 years ago

Just thought I would be nice and give back. I know nothing in XLights was ever borrowed from us. lol

Sent from my iPhone using Tapatalk


Reply
Posts: 1015
(@gilrock)
Noble Member
Joined: 14 years ago

Not from me...and all the effects I got ideas from SuperStar I didn't have any source code for reference I created all my own algorithms.


Reply
Posts: 1015
(@gilrock)
Noble Member
Joined: 14 years ago

I don't even know where the Vixen code base lives... In fact I remember Matt Johnson was asking me to put in some alignment features that he used in Vixen and I said I don't want to put that in because I don't want to copy anything that I could be accused of taking from them. He said don't worry he's the one that gave you guys half your ideas anyways.


Reply
Posts: 1049
(@phrog30)
Noble Member
Joined: 12 years ago

Just curious, but will changing the sub buffer size (larger) for this one effect have better results?

Sent from my SM-G900V using Tapatalk


Reply
Page 1 / 2
Share: